p2p/enode: add Pebble database support for node database #33009
+144
−84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hero5512
requested review from
fjl,
rjl493456442 and
zsfelfoldi
as code owners
hero5512
changed the title
fdtwd8vv45-sketch
approved these changes
Nov 7, 2025
Member
|
Honestly I don't think the complexity is worthwhile for migrating the node database. If we decide to deprecate the LevelDB totally, we can just switch to Pebble forcibly. |
Contributor
Author
Okay. I've simplified the implementation based on your suggestion. The node database now forcibly uses pebble and resets automatically when leveldb existence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR try to close #33000. It adds support for both LevelDB and Pebble in the p2p node database, allowing users to configure the database for migration to Pebble while maintaining backward compatibility.